Skip to content

feat: add retry in init phase instead of panic directly#1144

Merged
psbrar99 merged 3 commits into
envoyproxy:mainfrom
zirain:redis-init-retry
May 27, 2026
Merged

feat: add retry in init phase instead of panic directly#1144
psbrar99 merged 3 commits into
envoyproxy:mainfrom
zirain:redis-init-retry

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented May 25, 2026

fixes: #1143

Key Changes:

  • Redis Connection Retry Mechanism: Replaces immediate panic on Redis connection failure with exponential backoff retry, validates connection with PING before proceeding.
  • Context-Based Initialization: Adds context.Context throughout initialization chain for graceful cancellation, allows shutdown during startup retry phase.
  • Health Check Updates: Redis health now starts as unhealthy (was healthy), marked healthy only after successful connection confirmed.

zirain added 3 commits May 25, 2026 10:18
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain marked this pull request as ready for review May 25, 2026 05:08
@psbrar99 psbrar99 self-requested a review May 27, 2026 17:30
@psbrar99
Copy link
Copy Markdown
Contributor

LGTM, Thank you @zirain

@psbrar99 psbrar99 merged commit b8d893f into envoyproxy:main May 27, 2026
6 checks passed
@zirain zirain deleted the redis-init-retry branch May 27, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ratelimit Crashloop when starting

2 participants